- Rating
- 2
- Confidence
- 1
- Informativeness
- 2
- Presentation
- 2
- Soundness
- 2
Read review
Paper summary
This paper studies fast machine learning models for analog-circuit performance prediction. ThunderGen uses diffusion models to generate circuit topologies and device parameters, then filters the circuits using Cadence Spectre simulations. The reported dataset contains 44,555 circuits across five analog and RF circuit families. The proposed HybridGNN combines graph features, global descriptors, and separate prediction heads, with an estimator trained for each family. The paper compares the estimators with DiffCkt and FALCON on the generated data and reports an average MPRE of 16.11%, with improvement factors of 4.69 and 6.07. The dataset and pipeline have practical potential, but the interpretation of the accuracy metric and the evidence for unseen-topology generalization need clarification.
Critical strengths
The multi-family dataset and its construction pipeline could be a useful research resource. The work covers five circuit families and seeks to increase connectivity diversity beyond parameter sweeps on fixed topologies. The reported graph representations, netlists, testbenches, and simulation results, together with detailed model and training descriptions, could support more representative benchmarks for performance prediction (Table 3, page 10, and Appendices A.3-A.5.).
Critical weaknesses
- The main error calculation does not clearly establish prediction accuracy. Equation (1) is called MAE but averages squared residuals, and it compares specifications with simulated or predicted values. Appendix A.2 describes Table 7 as reporting this error. Some Table 4 entries can be reproduced from Table 7 aggregates: for LNA PowerGain, |14.78 - 15.15| / 15.15 gives approximately 2.44%. Similar aggregate errors relative to a specification do not imply that the prediction matches SPICE for each circuit. If Table 7 instead contains mean performance values, agreement between means is also insufficient. The reported 16.11% and improvement factors therefore remain difficult to interpret. This directly affects the main conclusion. (Equations 1-2 and Tables 4 and 7.)
- Generalization to unseen topologies is not sufficiently established. Table 11 gives a 90/5/5 split but does not state whether circuits are grouped by topology. Since Table 3 contains multiple instances per unique topology, different parameter instances of the same connectivity pattern could appear in both training and test sets. Such an evaluation would not establish generalization to unseen structures. The topology definition, overlap between splits, and results on topologies absent from training are needed. This is a validation gap, not evidence that leakage actually occurred. (Tables 3 and 11.)
Questions for authors
- What does each Table 7 cell represent: MAE or MSE relative to a specification, or mean performance? Are Table 4 errors calculated per circuit before averaging, or from aggregate values? Please provide errors directly comparing each prediction with its SPICE result, including the relative-error denominator and units. If the issue is a formula or label error, please explain the actual circuit-level calculation so that the headline result can be assessed.
- Are the training, validation, and test splits grouped by topology? How is topology identity defined, and how much overlap exists between splits? Please provide results on topologies absent from training, or report the performance on the unseen-topology subset of the current test set.
We thank the reviewer for the positive assessment of our dataset and for highlighting areas requiring clearer error metrics and evidence of topological generalization.
Q1) The actual implementation of Equation (1) computed the mean absolute deviation from specification targets, and Equation (2) measured aggregate consistency relative to Spectre deviations. We have corrected Equations (1) and (2) in the revised manuscript. We have also added a comprehensive evaluation reporting direct per-circuit prediction errors against Cadence Spectre ground truth across all 24 individual metrics spanning all five circuit families (Table 14 in Appendix A.8) and comparison with ML baselines evaluated against Spectre (Table 15 in Appendix A.8).
Q2) In our framework, circuits are mapped to attributed component graphs where nodes represent device types and edges represent shared electrical nets (excluding sizing parameters). Two circuits share a topology if and only if their labeled graphs are isomorphic. A topology is unique if it differs by at least one device or connection. We have updated Section 4.1 to better clarify this. Because our test set is drawn from a multi-topology pool (~28k unique topologies across ~44k circuits), 60.6% of the test samples feature topologies completely unseen during training. To address the question directly, we updated Table 4 in the revised manuscript to include a dedicated column evaluating performance strictly on these unseen topologies. On unseen topologies, ThunderGen maintains a robust 19.73% average MPRE, vastly outperforming DiffCkt (73.77%) and Falcon (100.28%). This confirms that ThunderGen learns generalizable circuit physics rather than memorizing familiar schematics.