- Rating
- 1
- Confidence
- 3
- Informativeness
- 1
- Presentation
- 1
- Soundness
- 1
Read review
Paper summary
S2S-Diff proposes a two-stage generative model for time series. It first learns a multi-scale dictionary of temporal atoms, and then maps each training sequence to atom-matching activations. However, the claims of sparse structural composition, controllability, and improved long-range modeling remain insufficiently substantiated, while inconsistencies in the formulas and reported results limit confidence in reproducibility.
Critical strengths
- Making a learned atom representation an explicit sampled variable is an interesting way to separate pattern selection from signal realization.
- The paper covers nine datasets from varied domains, compares multiple generative model families, and includes several ablations studies.
Critical weaknesses
-
The Introduction identifies a limitation of prior methods: they struggle to reconcile long-range structure with fine-grained dynamics. However, the paper does not clearly explain how the proposed atom-set representation captures long-range temporal organization.
-
The two purportedly complementary activation channels are deterministically redundant. From Equations (4)-(6), for nonnegative distances and fixed scale factor epsilon_s, p_hat[s,m,d] = exp(-(epsilon_s * dist_min[s,m,d])^2). Thus p_hat is a strictly monotone transform of dist_min, and one contains no additional information about the matching distances beyond the other.
-
Section 3.2 does not specify how atom values are initialized, how lengths are rounded for each dataset, or how the AttnFuse operation in Equation (7) is implemented. These choices affect the learned structural space and should be reported explicitly.
-
Sections 3.3-3.4 describe a Transformer prior over activations and a conditional Transformer signal denoiser. However, the paper does not explicitly state whether the two denoisers share any parameters. Equation (12) also switches from epsilon_phi in the text to epsilon_psi in the objective.
-
Section 3.5 establishes that S2S-Diff samples a structural variable from its own prior, whereas the cited alternatives use structural cues as guidance. This distinguishes model formulations, but does not by itself show that sampling structure separately is preferable.
-
Figure 4 labels two groups as "class 1" and "class 2," but neither the caption nor Section 4.3 names the dataset, defines the classes, or explains how samples and atoms were selected.
-
Algorithm 1 uses sqrt(alpha_k) and sqrt(1-alpha_k) to noise clean activations and signals at arbitrary step k, whereas Equation (16) uses cumulative alpha_bar_k.
-
Section 4.1 states that Context-FID improves by 50% on all nine datasets. Relative to the strongest baseline in Table 1, C.T. improves from 0.385 to 0.228 (about 40.8%) and J.V. from 0.119 to 0.113 (about 5.0%). The claim should be recalculated or narrowed.
-
Equation (8) defines lambda_1 for alignment, lambda_2 for atom L1 sparsity, and lambda_3 for diversity, with values 0.5, 0.001, and 0.1. Appendix H instead labels its sparsity sweep lambda_1 (centered at 0.001), diversity sweep lambda_2 (0.1), and alignment sweep lambda_3 (0.5). Please reconcile the notation so the reported configuration and sensitivity results are unambiguous.
Questions for authors
See Weaknesses.