- Rating
- 2
- Confidence
- 2
- Informativeness
- 2
- Presentation
- 2
- Soundness
- 2
Read review
Paper summary
This paper proposes FedSP, a federated domain generalization method for settings where each client holds data from a single source domain, with the goal of generalizing to unseen domains. Evaluation follows the leave-one-domain-out protocol, with each source domain split across two clients. The method has three modules. In CSAS, the server aggregates class prototypes computed by clients in two stages, within and across domains, based on reliability, and prototype contrastive losses (PCL and CCPL) align features across domains. DSRA adds a bottleneck-MLP residual to encoder features, which is claimed to complement shared semantics with domain-specific discriminative attributes; however, its parameters are also aggregated on the server. MUCL combines client-side regularization via evidential learning with server-side aggregation that mixes sample-size-based weights with a term assigning larger weights to clients on which the global model has higher predictive entropy. Using an ImageNet-pretrained ResNet-50 as the backbone, the paper reports higher average accuracy than existing methods on PACS, Office-Home, Office-Caltech10, and Terra Incognita.
Critical strengths
The paper addresses a well-motivated question in FedDG, namely how to handle shared versus domain-specific knowledge. It organizes the method around three clear questions (what to share, what to adapt, and how to constrain learning), which makes the overall design easy to follow. FedSP achieves the best average accuracy on all four benchmarks. The improvement of about 6 points over the FedAlign baseline on Terra Incognita, a realistic dataset with large domain shifts, is particularly convincing. In the ablation study, adding or removing each module affects performance in a consistent direction, indicating that the components work well together. The hierarchical prototype aggregation (HPA), which uses sample counts, variance, and cross-domain consistency, is a concrete and easily implementable design and forms the core of CSAS, the module with the largest contribution on PACS. The comprehensive hyperparameter table and the stated code release also reflect good attention to reproducibility.
Critical weaknesses
First, the meaning of "personalized" is unclear. Since DSRA parameters are aggregated on the server and end up shared by all clients, there is no personalized component in the usual sense. No constraint or analysis supports the claim that ΔH carries domain-specific information, and its contribution in the ablation is small. Second, the motivation for and analysis of each module are thin. ELR and PEA are not explicitly connected, and PEA's upweighting of uncertain clients runs opposite to the introduction's framing of "client reliability." Third, the ablation is conducted only at the module level with a single seed, so the contributions of PCL versus CCPL and ELR versus PEA are not separated. Fourth, the evaluation setting is limited. There are only two clients per domain, widely used datasets such as DomainNet and VLCS are not included, and neither standard deviations nor the model selection procedure is reported. In addition, the text states margins over the second-best method of 0.54 points on Office-Caltech10 and 5.89 points on Terra Incognita, but these are margins over FedAlign. The margins over the actual second-best methods in the tables (DI and GA) are only 0.07 and 2.95 points, respectively. Finally, the relationship to CLIP-based methods that use domain-specific prompts is not discussed. Combined with the fact that each component builds on existing techniques, this leaves the novelty weakly positioned.
Questions for authors
-
Definition of "personalized" and the role of DSRA: DSRA parameters are aggregated on the server and end up shared by all clients. What does "personalized" refer to in this paper? Please explain why these parameters are aggregated, and compare performance against keeping them per client without aggregation. Can you also provide analysis showing that ΔH actually carries domain-specific information?
-
Granularity of the ablation study: The current ablation is conducted at the module level with a single seed. Can you provide results that separately remove PCL and CCPL, and ELR and PEA, over multiple seeds?
-
Scale of the evaluation and scalability: Please state the total number of clients and how each domain is split. Can you report results with more clients per domain (e.g., 10), on DomainNet (or miniDomainNet) and VLCS, and with standard deviations for the main experiments? Also, since CCPL's communication grows with the number of clients times the number of classes, how do you view its applicability in large-scale settings?
-
Relationship to CLIP-based Federatd methods: CLIP-based federated methods that use domain-specific prompts (e.g., FedDSPG, ADAPT) also separate shared and domain-specific knowledge. Please clarify how FedSP differs from these methods and what its novelty is relative to them. Are CSAS and DSRA applicable on top of frozen CLIP features?