- Rating
- 3(+1)
- Confidence
- 4
- Informativeness
- 2
- Presentation
- 2
- Soundness
- 2
Read review
Paper summary
This paper introduces FlexMOF, whose main contributions and scientific significance lie in two aspects. First, and most importantly, it integrates building-block generation with all-atom diffusion, substantially increasing the flexibility of MOF generation compared with previous approaches. The joint training strategy is also well-motivated, as the generation of building blocks should account for the constraints imposed by periodic crystal structures. Second, FlexMOF introduces an attention architecture operating at the atom, block, and cell levels. Overall, I believe this work has sufficient scientific merit, as all-atom MOF generation is undoubtedly an important task in materials science. Nevertheless, several closely related works deserve attention. In particular, Mofasa has already demonstrated all-atom MOF generation, while Crystalformer has explored periodic attention mechanisms (which the authors do not appear to cite), with a formulation highly similar to the proposed cell-level attention. Despite these concerns, given the strong experimental results, I still consider this work worthy of acceptance. However, I believe the authors should address several important questions, particularly regarding the practical generalizability of the proposed method and the actual benefits of joint training for generation.
Critical strengths
- Unified framework. The paper unifies crystal structure prediction and de novo MOF generation within a coherent framework, providing a clear and well-motivated approach to both tasks.
- Joint composition–structure learning. The proposed method integrates building-block generation with all-atom coordinate diffusion through joint training, effectively improving generation quality.
- Efficient attention design. The attention architecture incorporates atom-level, building-block-level, and periodic cell-level interactions, enabling efficient modeling of relatively large MOF systems.
- Comprehensive experiments. The experimental evaluation is thorough and well-designed, covering not only structure recovery and generation quality but also important MOF properties, particularly pore geometry.
- Strong empirical performance. FlexMOF demonstrates substantial improvements over existing baselines across multiple evaluation metrics, providing convincing evidence of its effectiveness.
Critical weaknesses
- Unclear benefits of joint training for composition generation. My primary concern is how joint training actually changes the learned representations and generation behavior of the building-block autoencoder. Given the authors' emphasis on periodicity, I would like to understand what limitations arise when building blocks are generated without structural supervision. For example, are independently generated building blocks less likely to assemble into valid periodic MOF structures?
- Limited evaluation of generalizability. The experiments are primarily conducted on the hypothetical BW dataset, while more realistic MOF datasets, such as CoRE MOF, are also important. It remains unclear whether FlexMOF can effectively perform all-atom training and inference on these datasets, particularly given the larger size and structural complexity of real MOFs.
- Insufficient discussion of related work. The paper does not appear to cite Crystalformer, which introduces a periodic attention mechanism that is mathematically very similar to the proposed cell-level attention. The authors should clarify the methodological differences and the novelty of their design.
- Lack of computational efficiency analysis. The paper does not provide a systematic analysis of computational cost or scalability, and the experiments appear to focus on MOFs of limited size. Since MOFs can be substantially more complex than conventional crystals, the computational feasibility of all-atom generation for larger and more complicated frameworks remains an important concern.
Questions for authors
see Weakness. If the authors can provide an interpretable analysis of the actual benefits of joint training (rather than merely reporting improvements in final performance) and demonstrate the efficiency and effectiveness of their model on real-world MOF datasets, I would be willing to raise my score.
7 comments
Weakness 2: Demonstrate training and generation on complex experimental MOFs
We have conducted preliminary experiments to show that FlexMOF can be trained on experimental MOF structures and support de novo generation across a broad range of system sizes.
We constructed an experimental MOF training dataset comprising 25,683 structures from publicly accessible sources, including QMOF, the computation-ready subset of CoRE-MOF-2024 SI, the CSD-modified computation-ready CoRE-MOF structures, and ARC-MOF DB12/DB14 structures. Some additional CSD-derived structures require licensed access and are not included in our current dataset.
We use Mofasa as the primary literature reference for experimental-MOF generation because it provides the closest available comparison in task scope and training-data provenance. Its experimental model generates complete all-atom MOF structures and is trained on a mixture of QMOF, computation-ready CoRE-MOF-2024, and ARC-MOF structures, closely corresponding to the sources used in our experimental dataset. Moreover, its evaluation extends to 500 atoms per unit cell and reports validity rates, directly addressing the reviewer’s concerns about realistic structural complexity and generative effectiveness.
Our experimental training set is considerably smaller than the hypothetical BW dataset and also smaller than the approximately 49,000 experimental structures used to train Mofasa. We jointly train FlexMOF's composition and all-atom structure generation modules on our experimental training set, using the same general modeling framework without introducing experimental-dataset-specific architectural modifications.
We sample 10,000 MOFs from the model trained with the experimental MOF dataset. We evaluate generation quality by grouping outputs according to their actual atom counts, including hydrogen, and reporting the validity rates in each interval. Mofasa reference values are approximate estimates obtained by interpolating its published unconditional-generation curve in Figure 7 (without geometry relaxation) of its paper at the atom counts of our samples and averaging within each interval.
\hline \textbf{Atoms per cell} & \begin{array}{c}\textbf{FlexMOF} \\\\ \textbf{validity (\\%) }\uparrow\end{array} & \begin{array}{c}\textbf{Mofasa} \\\\ \textbf{validity (\\%)}\end{array} \\\\ \hline \text{10–100} & \textbf{59.03 }\text{(2,658/4,503)} & \text{58.29} \\\\ \text{101–200} & \textbf{51.35}\text{ (1,616/3,147)} & \text{49.28} \\\\ \text{201–300} & \textbf{29.82 }\text{(339/1,137)} & \text{29.79} \\\\ \text{301–400} & \textbf{24.09 }\text{(159/660)} & \text{18.20} \\\\ \text{401–500} & \textbf{16.19 }\text{(40/247)} & \text{7.72} \\\\ \text{>500} & \textbf{10.73 }\text{(31/289)} & \text{—} \\\\ \hline \end{array}$$ FlexMOF’s observed validity is comparable to or higher than the approximate Mofasa reference values in most evaluated size intervals. These results are encouraging for larger frameworks and demonstrate that FlexMOF can generate valid structures containing more than 500 atoms per unit cell. However, differences in training subsets (we will collect more experimental MOF data in the future) and conditioning protocols mean that this comparison provides context rather than a controlled ranking. These preliminary experiments support the applicability of FlexMOF to experimental MOFs across a broad size range. Improving generation quality and diversity, particularly for larger frameworks, remains an important direction for further work.Weakness 3: Clarify the relationship to Crystalformer and the methodological contribution
We agree that the core log-sum-exp formulation of our source-atom aggregation is mathematically equivalent to the periodic-image attention reduction in Crystalformer. We have explicitly acknowledged and discussed this connection in Sections 2 and 3.2 of the revised manuscript, rather than claiming the aggregation formula itself as a new attention mechanism.
However, our methodological contribution lies in extending this aggregation to chemically conditioned, dynamic periodic structure generation, which introduces two important distinctions:
Dynamic periodic geometry modeling. Unlike Crystalformer, which encodes given periodic structures for property prediction, FlexMOF jointly denoises atomic coordinates and unit-cell geometry in Cartesian space. As both evolve, the periodic multigraph and its neighboring periodic images are dynamically reconstructed at each denoising step. While attention contributions from images of the same source atom are aggregated, their individual relative displacement vectors are retained to guide atomic and lattice-coordinate updates. This enables efficient periodic attention within a generative process where the underlying periodic geometry continuously changes (Sections 3.1–3.2 and Appendix D.2).
Chemical graph conditioning. FlexMOF further integrates chemical connectivity information from the molecular graphs of MOF building blocks, including linker bond connectivity, into the attention computation. Specifically, Graphormer-style shortest-path and bond-path biases provide chemical context alongside the geometric interactions from periodic images. This allows the model to jointly consider molecular connectivity and spatial periodic interactions when predicting atomic and lattice-coordinate updates (Sections 3.1–3.2 and Appendix B.3).
These distinctions clarify that our contribution is not a new periodic-attention aggregation formula, but its extension to chemically conditioned, dynamically evolving all-atom periodic structure generation. We have revised the related-work discussion accordingly.
Response to Reviewer D4nb
We thank the reviewer for the careful assessment and constructive suggestions on joint learning, experimental-MOF applicability, related work, and scalability. We hope the reviewer will carefully consider the additional evidence and clarifications below when reassessing our submission.
Weakness 1: Explain how structural supervision improves building-block chemistry and assembly
We have conducted additional experiments to investigate how structural supervision improves composition generation, including a controlled comparison using a fixed structure predictor and an analysis of generated chemical graphs.
1. Improved ability to form valid periodic MOF structures. We compare independently trained and jointly trained composition generators using the same fixed structure-predictor weights and 10,000 generation requests. As reported in Section 4.5, Table 3 of the revised manuscript, the results are:
\hline \textbf{Composition generator} & \textbf{Validity (\\%) }\uparrow & \textbf{EVNU (\\%) }\uparrow \\\\ \hline \text{Independently trained} & \text{56.79} & \text{49.61} \\\\ \text{Jointly trained (FlexMOF)} & \textbf{79.82} & \textbf{69.73} \\\\ \text{Improvement} & \textbf{+23.03} & \textbf{+20.12} \\\\ \hline \end{array}$$ These substantial improvements indicate that **compositions learned with structural supervision are more suitable for generating valid periodic MOF structures**, rather than the improvements arising solely from changes in the structure-prediction model. **2. Improved chemical connectivity of generated building blocks.** We further analyze the chemical graphs produced by the two composition generators and their resulting structures: $$\begin{array}{lcc} \hline \begin{array}{c}\textbf{Chemical consistency} \\\\ \textbf{issue}\end{array} & \begin{array}{c}\textbf{Separate training} \\\\ \textbf{(\\%) }\downarrow\end{array} & \begin{array}{c}\textbf{Joint training} \\\\ \textbf{(\\%) }\downarrow\end{array} \\\\ \hline \text{Disconnected linker graphs} & \text{3.64} & \textbf{2.60} \\\\ \begin{array}{c}\text{Carbon atoms with more} \\\\ \text{than four graph neighbors}\end{array} & \text{6.65} & \textbf{4.41} \\\\ \begin{array}{c}\text{Structures flagged for} \\\\ \text{carbon undercoordination}\end{array} & \text{22.48} & \textbf{11.33} \\\\ \hline \end{array}$$ Carbon undercoordination refers to **carbon atoms having insufficient bonding neighbors for their expected chemical environment**, potentially indicating missing bonds, missing hydrogen atoms, or incorrect local geometry. Unlike the first two metrics, which directly assess generated chemical graphs, carbon undercoordination is detected by MOFChecker from the resulting 3D structures. These results reveal concrete limitations of composition generation without structural supervision: independently trained generators produce more disconnected or chemically implausible building-block graphs, and their resulting structures exhibit more coordination defects. In FlexMOF, coordinate-denoising supervision influences the shared composition representations and graph-posterior latents during joint training (**Section 3.4 and Appendix E.1**). This connects chemical graph learning to the geometric constraints of periodic structure formation. **Together, these results provide empirical evidence that structural supervision improves both the chemical consistency of generated building blocks and their compatibility with valid periodic MOF structures.**