- Rating
- 2
- Confidence
- 3
- Informativeness
- 2
- Presentation
- 2
- Soundness
- 2
Read review
Paper summary
RhoEdit addresses the trade-off between model editing and capability preservation through a gradient adjustment based on capability curvature relative to edit curvature, using K-FAC to approximate both curvature matrices. Experiments cover three datasets on Llama-3-8B-Instruct, cross-model evaluation on Qwen2.5-7B-Instruct, and scaling to 10,000 ZsRE edit requests on Llama. The reported results show a competitive editing–preservation balance on the main model.
Critical strengths
1.The paper proposes an interpretable relative-curvature gradient adjustment that accounts for both editing and capability preservation. Generalized eigendecomposition clarifies the mechanism, while K-FAC enables implementation at LLM scale.
2.On Llama, RhoEdit combines strong editing with limited degradation in average capability benchmark performance across three datasets. At 10,000 ZsRE edits, it leads the reported baselines in editing performance while largely retaining average performance on the five capability benchmarks.
Critical weaknesses
1.Figure 2 only examines capability-set size and penalty strength, without isolating the contribution of edit curvature. Although capability-preserving baselines such as CrispEdit are compared, the existing experiments do not establish whether the gains arise specifically from incorporating edit curvature rather than capability curvature alone.
2.As acknowledged in Appendix B.1, the penalty–cost correspondence applies only to the local quadratic minimizer. The implementation instead uses Adam after relative-curvature adjustment, replacing Eq. (4)’s Newton preconditioner. How the local analysis translates into capability preservation under the actual optimizer updates remains insufficiently established.
Questions for authors
1.On Qwen2.5-7B-Instruct with CounterFact, RhoEdit underperforms LocFT-BF in both average editing and capability scores (Table 3). What explains this result?
2.Given the numerical instability noted in Section 3.1, how sensitive are editing performance and capability preservation to the damping applied to the edit-curvature factors?
3.Figure 2(a) examines the size of the capability reference set. What is the composition of this set, and how sensitive is capability preservation to the choice of reference data?
4.Appendix D.5 provides asymptotic complexity, but what are the measured runtime and peak GPU memory costs, including curvature estimation, eigendecomposition, and optimization?
2 comments
Question 1. On Qwen2.5-7B-Instruct with CounterFact, RhoEdit underperforms LocFT-BF in both average editing and capability scores (Table 3). What explains this result?
Response: Thank you for highlighting this result. LocFT-BF directly fine-tunes a localized layer, which can be particularly effective when the selected layer supports the requested edits while limiting interference with other capabilities. This may explain its strong performance on Qwen2.5-7B-Instruct.
However, its effectiveness appears highly model-dependent: its average editing scores fall from 57.3–76.7 on Qwen to 10.6–18.8 on Llama-3-8B-Instruct. RhoEdit provides more consistent performance across model families, ranking first or second in average editing performance across all six model–dataset combinations while generally retaining strong capability scores. Although LocFT-BF performs better in this particular setting, RhoEdit maintains a competitive editing–preservation balance across both models.
Question 2. Given the numerical instability noted in Section 3.1, how sensitive are editing performance and capability preservation to the damping applied to the edit-curvature factors?
Response: Thank you for raising this question. The numerical instability noted in Section 3.1 arose in our early attempts to use inverse edit curvature directly as a Newton preconditioner. With curvature estimated from a small edit dataset, inversion can strongly amplify components associated with very small eigenvalues, producing excessively large updates and preventing meaningful training. We tried damping in these preliminary experiments, but it did not sufficiently resolve the instability in the settings we tested. This motivated our choice to apply the relative-curvature gradient adjustment and let Adam convert the adjusted gradient into a parameter update.
Question 3. Figure 2(a) examines the size of the capability reference set. What is the composition of this set, and how sensitive is capability preservation to the choice of reference data?
Response: Following CrispEdit, we use Wikipedia samples as the capability set. We keep this corpus fixed and have not tried alternatives. We expect other broad pretraining corpora to provide similar preservation signals, given their shared coverage of general language and knowledge. The limited sensitivity to capability-set size in Figure 2(a) is consistent with this intuition.
Question 4. Appendix D.5 provides asymptotic complexity, but what are the measured runtime and peak GPU memory costs, including curvature estimation, eigendecomposition, and optimization?
Response: Thank you for requesting these measurements. We report the measured editing time and peak GPU memory on Llama-3-8B-Instruct with 3,000 ZsRE edits, using one NVIDIA L40 GPU. The table below reports editing time.
| Method | Editing time | Peak GPU memory |
|---|---|---|
| MEMIT | 16h 53m | 46 GB |
| FT | 8m 58s | 45 GB |
| AlphaEdit | 12h 30m | 42 GB |
| CrispEdit | 24m 9s | 45 GB |
| RhoEdit | 44m 47s | 47 GB |
For RhoEdit, the stage breakdown is approximately 1h 39m for curvature estimation, 4m 5s for eigendecomposition, and 44m 47s for optimization.
Curvature estimation accounts for most of the preprocessing cost. For fixed model parameters, and reference and edit datasets, the curvature factors and decompositions can be cached and reused across penalty-strength settings, since they do not depend on the penalty strength. We will include these runtime and memory measurements in the revised manuscript.
Thank you for your thoughtful review. We address your concerns below.
Weakness 1. Figure 2 only examines capability-set size and penalty strength, without isolating the contribution of edit curvature. Although capability-preserving baselines such as CrispEdit are compared, the existing experiments do not establish whether the gains arise specifically from incorporating edit curvature rather than capability curvature alone.
Response: Thank you for this suggestion. We conducted an additional ablation on Llama-3-8B-Instruct with 3,000 ZsRE edits, replacing edit curvature with the identity matrix. The gradient adjustment then becomes
=(I+\lambda G_{\mathrm{cap}})^{-1}g_{\mathrm{edit}}.$$ This variant retains our continuous attenuation mechanism while removing its dependence on edit curvature. We also include CrispEdit, which uses capability curvature to project gradients onto a low-curvature subspace. | Method | QA context Rel. | QA context Gen. | No context Rel. | No context Gen. | Edit Avg. | MMLU | IFEval | TruthfulQA | ARC-C | GSM8K | Base Avg. | |:--|--:|--:|--:|--:|--:|--:|--:|--:|--:|--:|--:| | CrispEdit | 81.9 | 70.4 | 60.4 | 51.0 | 65.9 | 69.7 | 67.8 | 53.0 | 57.3 | 77.1 | 65.0 | | RhoEdit without edit curvature | 83.17 | 66.47 | 64.23 | 51.30 | 66.29 | 69.39 | 70.05 | 52.59 | 56.48 | 77.33 | 65.17 | | RhoEdit | 86.40 | 69.60 | 65.87 | 54.27 | **69.04** | 69.43 | 73.01 | 52.51 | 56.48 | 77.94 | **65.89** | Incorporating edit curvature improves the average editing score by **2.75 points** and the average capability score by **0.72 points** over the ablated variant. RhoEdit also achieves higher editing and capability averages than CrispEdit. Together, these comparisons support the contribution of edit curvature beyond capability curvature alone: the improvement in editing is accompanied by stronger capability preservation. --- **Weakness 2. As acknowledged in Appendix B.1, the penalty–cost correspondence applies only to the local quadratic minimizer. The implementation instead uses Adam after relative-curvature adjustment, replacing Eq. (4)’s Newton preconditioner. How the local analysis translates into capability preservation under the actual optimizer updates remains insufficiently established.** **Response:** Thank you for raising this point. Our derivation separates the local quadratic solution into a relative-curvature gradient adjustment and subsequent Newton preconditioning. RhoEdit retains the former and uses Adam for the latter, since direct inverse-curvature preconditioning led to numerical issues in our preliminary experiments. The theoretical characterization of the adjustment remains valid: before entering Adam, gradient components are attenuated according to their relative capability curvature, with stronger attenuation in directions of greater relative capability sensitivity. The penalty–cost correspondence applies specifically to the local quadratic minimizer, while the preservation achieved by the complete optimization procedure is evaluated empirically. Our main experiments directly evaluate the complete method with Adam. Across the three datasets on Llama-3-8B-Instruct, RhoEdit achieves an average editing score of 68.8 while retaining a general-capability average of 65.1, compared with 65.4 for the unedited model. These results support the effectiveness of the theoretically motivated adjustment under the optimizer used in practice.