- Rating
- 2
- Confidence
- 2
- Informativeness
- 2
- Presentation
- 3
- Soundness
- 2
Read review
Paper summary
The paper proposes HoReN, a codebook-based parameter-preserving model editing method that models knowledge keys as Hopfield stored patterns and combines angular retrieval on the unit hypersphere with damped Hopfield dynamics to achieve more robust edit retrieval and paraphrase generalization. Extensive experiments are conducted to validate the effectiveness of the proposed method.
Critical strengths
The paper projects keys and queries onto the unit hypersphere, replacing magnitude-sensitive Euclidean matching with cosine similarity.
The experiments in this paper are detailed and thorough.
The written expression in the paper is relatively clear.
Critical weaknesses
Figure 1 shows that, as the number of sequential edits increases, different methods exhibit different forms of overall performance degradation. However, this evidence mainly reflects performance-level degradation and may not be sufficient on its own to attribute the issue specifically to routing.
The treatment of the query over the memory keys in the Hopfield refinement is reasonable; however, I believe there is still room for discussion as to whether the methodological novelty is sufficient to support the relatively strong theoretical framing adopted in the paper.
Since , please compare against generic normalized attention/kernel-smoothing retrieval to clarify the algorithmic novelty.
The theory analyzes the standard unnormalized Hopfield operator, whereas HoReN actually uses a normalized, damped, one-step operator.
Questions for authors
Refer to the above text.
3 comments
part 2
Point 3 (Theory) Theory for the deployed operator
Response
Thank you for noting the operator difference. As stated in Section 2.3 and Appendices A and D, the original theory motivates limiting memory attraction; it was not presented as a retrieval or locality guarantee for the deployed one-step rule. We have extended the analysis to the actual normalized, damped operator to make the connection explicit.
1. Analysis of the deployed operator.
For a fixed finite codebook, define
\quad T(q)=\nabla F(q), \quad E(q)=\tfrac12\|q\|^2-F(q),$$ and $$u(q)=\frac{T(q)}{\|T(q)\|}, \qquad H_\gamma(q)=\operatorname{normalize}\bigl((1-\gamma)q+\gamma u(q)\bigr).$$ For unit $q$, $T(q)\ne0$, and $0<\gamma<1/2$, the deployed update satisfies $$E(H_\gamma(q))-E(q) \le-\frac{1-\gamma}{2\gamma}\|T(q)\|\, \|H_\gamma(q)-q\|^2\le0.$$ With fixed $\|k_i\|\le1$ and $T(q_0)\ne0$, its ideal repeated iteration also converges to a codebook-induced fixed point. This concerns exact arithmetic before fixed-step or epsilon stopping. The following proof applies directly to $H_\gamma$. **Proof of the added result and displacement bound.** Assume a fixed finite codebook, $\|k_i\|\le1$, $\beta>0$, unit $q_0$ with $T(q_0)\ne0$, and constant $0<\gamma<1/2$. We use exact updates without epsilon stopping. **Energy descent.** Write $g=T(q)=\nabla F(q)$, $u=g/\|g\|$, $v=(1-\gamma)q+\gamma u$, and $q^+=v/\|v\|$. Since $\|v\|\ge1-2\gamma>0$ and $q^+$ maximizes $v^\top z$ over unit $z$, $$v^\top(q^+-q)\ge0 \quad\Longrightarrow\quad \gamma u^\top(q^+-q)\ge\frac{1-\gamma}{2}\|q^+-q\|^2.$$ Convexity of $F$ then gives $$F(q^+)-F(q)\ge g^\top(q^+-q) \ge\frac{1-\gamma}{2\gamma}\|g\|\|q^+-q\|^2.$$ Both queries have unit norm, so their quadratic energy terms cancel, yielding the stated descent inequality. **Uniform nondegeneracy.** The set $S=\{q:\|q\|=1,F(q)\ge F(q_0)\}$ is compact and contains the trajectory. It contains no zero of $\nabla F$: such a zero would be a global minimizer of the convex function $F$, forcing $q_0$ also to be a minimizer and contradicting $T(q_0)\ne0$. Therefore $m=\min_{q\in S}\|T(q)\|>0$, and $$E(q_s)-E(q_{s+1})\ge a\|d_s\|^2, \qquad a=\frac{(1-\gamma)m}{2\gamma},\quad d_s=q_{s+1}-q_s.$$ Thus energies converge and $d_s\to0$. The constant $m$ is not asserted to be uniform across codebooks or edit scales. **Single-limit convergence.** Let $P_q=I-qq^\top$ and $b_s=\|(1-\gamma)q_s+\gamma u(q_s)\|\le1$. Projecting the update onto the tangent space gives $$\|\operatorname{grad}_{\mathbb S}E(q_s)\| =\|P_{q_s}T(q_s)\| \le\frac{\|T(q_s)\|b_s}{\gamma}\|d_s\| \le\frac1\gamma\|d_s\|.$$ The restriction of $E$ to the sphere is real analytic. Equivalently, $\widetilde E(x)=1/2-F(x/\|x\|)$ is an analytic extension near the sphere, whose gradient on the sphere is the above tangent gradient. Its KL inequality, uniformized near the compact accumulation set at limiting energy $E_\infty$, gives a concave desingularizing function $\varphi$. Combining the preceding two inequalities yields, for sufficiently large nonstationary $s$, $$\varphi(E(q_s)-E_\infty)-\varphi(E(q_{s+1})-E_\infty) \ge a\gamma\|d_s\|.$$ Summation proves finite trajectory length, hence convergence to $q_*$. Continuity of $H_\gamma$ on $S$ and $d_s\to0$ give $H_\gamma(q_*)=q_*$. If the energy becomes constant, sufficient descent makes the sequence stationary. This follows the Appendix D KL argument; see [Absil et al.](https://doi.org/10.1137/040605266). **Single-step displacement.** For fixed unit $q$, the vector $(1-\gamma)q+\gamma u$ lies on the sphere with center $(1-\gamma)q$ and radius $\gamma$. Its maximum angle from $q$ is $\arcsin(\gamma/(1-\gamma))$. Consequently, $$\|H_\gamma(q)-q\| \le\sqrt{2-2\sqrt{1-(\gamma/(1-\gamma))^2}},$$ which is approximately 0.111283512 at $\gamma=0.1$. These are fixed-codebook, exact-arithmetic statements; they do not establish task accuracy, finite-precision convergence, or convergence across changing codebooks. **2. Why one step is selected.** Editing also requires rejecting unrelated queries, which the energy does not distinguish from edits. Damping bounds adjustment (0.111284 at $\gamma=0.1$); the step count is selected empirically. Table 12 and Figure 10 report the step-count ablation at 1,000 ZsRE edits on LLaMA-3.1-8B, with $\beta=20$ and $\gamma=0.1$: | Refinement steps M | Gen (%) | Loc (%) | Reported OP (%) | |---:|---:|---:|---:| | 1 | 92.6 | 99.3 | 97.0 | | 2 | 92.8 | 94.3 | 95.5 | | 4 | 93.0 | 52.1 | 78.4 | One step has the highest reported OP among these tested step counts. Increasing from one to four steps improves Gen by 0.4 percentage points while reducing Loc by 47.2 points. Thus, the theory motivates limited attraction, damping controls its magnitude, and the ablation selects the one-step operating point. We will make this separation explicit in Section 2.3 and include the deployed-operator analysis and proof.Thank you for your detailed point-by-point responses. After thoroughly consideration, I have decided to maintain my original rating.
part 1
Point 1 (Potential Exp) Evidence attributing degradation to routing
Response
We agree that Figure 1 shows how end-to-end performance changes with edit count. To test the role of routing directly, we varied GRACE's initial Euclidean radius on the same 1,000-edit ZsRE stream with LLaMA-3.1-8B-Instruct. We held the backbone, editing layer, pooling, and value-training recipe fixed and rebuilt memory at each setting. Increasing the initial radius from 1.0 to the calibration-selected 6.8173 raised Gen from 6.66% to 33.57%, with Loc at 100% in both runs and Rel above 98%. In the descriptive sweep, GRACE with normalized keys and queries and adaptive cosine-distance radii reached 61.30% Gen at 99.90% Loc.
These results show that routing choices materially affect paraphrase performance in the tested GRACE setup, where original edit prompts already have high reliability. The routing rule can also change which entries are allocated or reused during editing.
Reported routing-calibration results.
Point 2 (Exp) Novelty over normalized attention and smoothing
Response
Thank you for asking us to clarify the relationship to normalized attention and kernel smoothing. We address the shared mathematical operation, the editing-specific design, and the corresponding controls separately.
1. Relationship to attention and kernel smoothing.
The weighted read u(q)=normalize(∑ipi(q)ki), with pi(q)∝exp(20q⊤ki), is a normalized attention read. For unit queries and keys,
exp(20q⊤ki)=e20exp(−10∥q−ki∥2),
so the same weights correspond to a Gaussian kernel with squared bandwidth 1/20. The weighted-read operation is shared with these methods. HoReN uses this read within a sequential editor: it blends the direction with the original query using γ=0.1, normalizes the result, applies a hard acceptance threshold, and uses the resulting match for both inference and online memory allocation. A normalized-attention implementation with the same blend would implement the same one-step refinement formula. We will frame the contribution around this editing design and its empirical behavior, rather than presenting the shared attention operation as a distinct new primitive.
2. Direct normalized-attention control.
We compare against direct replacement of the routing query by u(q) on the same 1,000-edit ZsRE stream with LLaMA-3.1-8B-Instruct. Each method builds its own memory. The following are the original reported results, in percentages.
The second attention threshold was selected under the fallback calibration target of 75.12% Loc. At the reported test settings, the damped blend achieves higher Gen and Loc than direct replacement. This comparison tests how the weighted read is combined with the original query, including its effect on memory construction. Its result supports controlling the strength of the update; it does not distinguish HoReN from attention methods implementing the same residual blend.
3. Evidence for the memory-construction effect.
Refinement also operates before the editor decides whether to allocate a new key or reuse a same-label entry. We investigated this effect using the same-step Top-1 control discussed in our additional experiments. On a selected 100-example sequence with fixed edit order, five additional initializations give:
Each run has seven HoReN wins, one Top-1 win, and 92 ties. For those seven winning paraphrases, both routers succeed when given HoReN's memory, and both fail when given Top-1's memory. This swap identifies a memory-coverage effect: the refinement rule changes which keys are stored, with HoReN retaining more entries in this case. These are repeated initializations of one selected sequence, not independent editing streams. The case study uses float32 threshold comparison, while the default-stream controls use the legacy BF16 gate; one of the seven allocation differences is precision-sensitive.
Together, these experiments show how the query update affects thresholded routing and memory construction. We will separate this editor-level contribution from the underlying attention formula and align the framing with the analysis in Point 3.