- Rating
- 2
- Confidence
- 3
- Informativeness
- 2
- Presentation
- 2
- Soundness
- 2
Read review
Paper summary
The paper studies federated learning with nonlinear local and global functional constraints (Eq. 1), a setting where existing constrained-FL analyses rely on Lagrangian duality, constraint qualifications, or full participation. It proposes AdaP-SCAFFOLD, which extends SCAFFOLD's control variates with a round-varying penalty parameter and local stepsize updated by analytically derived rules (Algorithm 1). Constraint enforcement uses an eta-Moreau-smoothed ReLU penalty that grows linearly in the infeasible region, preserves the feasible set exactly, and admits explicit local Lipschitz constants (Definition 3.1 and Proposition 3.6). In the convex setting the method achieves O(eps^-2) communication complexity for both suboptimality and constraint violation, improving to O(eps^-1) under strong convexity, matching the eps-dependence of unconstrained SCAFFOLD (Theorems 4.1 and 4.3), and the upper bounds hold without constraint qualifications. Experiments on MNIST, EMNIST, and CIFAR-10 compare against ProxAL and unconstrained FL baselines, reporting competitive accuracy with consistently lower constraint violation.
Critical strengths
- The problem coverage is a genuine step forward for constrained FL. Handling client-specific and shared functional constraints together with stochastic gradients, partial participation, and drift correction covers a combination that Table 1 shows prior work does not, and obtaining upper bounds on both suboptimality and infeasibility without constraint qualifications is a real theoretical convenience.
- The Moreau-smoothed penalty is a well-chosen technical device. Proposition 3.6 shows it preserves the exact feasible set while restoring global smoothness, and this translates into visible empirical behavior, for example on EMNIST the average violation drops from about 0.095 for ProxAL to 0.008 with feasible ratio rising from 0 to 0.67 (Table 2).
Critical weaknesses
- The experiments do not test the paper's central algorithmic claim. The single constrained-FL competitor, ProxAL, is evaluated under its own full-participation full-gradient regime rather than the partial-participation stochastic setting the theory targets, the unconstrained baselines in Figures 2 and 3 cannot satisfy constraints by construction so the comparison is expected, and no ablation isolates the adaptive penalty and stepsize rules against a fixed well-tuned penalty, which is the core design contribution.
- There is an unaddressed theory-practice gap and the rates are weak in the constants. The guarantees assume convex objectives and constraints, yet all experiments train neural networks, and the bounds carry factors like exp(448 c_l^2 L_f^2) in Theorem 4.1, so the matched eps-dependence is meaningful only as an asymptotic statement. Absolute accuracy is also low (about 0.40 on CIFAR-10), leaving practical relevance undemonstrated.
Questions for authors
- The experiments do not test the paper's central algorithmic claim. The single constrained-FL competitor, ProxAL, is evaluated under its own full-participation full-gradient regime rather than the partial-participation stochastic setting the theory targets, the unconstrained baselines in Figures 2 and 3 cannot satisfy constraints by construction so the comparison is expected, and no ablation isolates the adaptive penalty and stepsize rules against a fixed well-tuned penalty, which is the core design contribution.
- There is an unaddressed theory-practice gap and the rates are weak in the constants. The guarantees assume convex objectives and constraints, yet all experiments train neural networks, and the bounds carry factors like exp(448 c_l^2 L_f^2) in Theorem 4.1, so the matched eps-dependence is meaningful only as an asymptotic statement. Absolute accuracy is also low (about 0.40 on CIFAR-10), leaving practical relevance undemonstrated.