- Rating
- 1
- Confidence
- 3
- Informativeness
- 1
- Presentation
- 2
- Soundness
- 2
Read review
Paper summary
This paper studies the failure cases of the popular optimization method Adam and demonstrates that in certain conditions Adam fails to converge in the sense of online learning regret.
The main improvement is that it extends the non-convergence results of Reddi et al. (2018) to arbitrary , using a sequence of linear functions with uniformly bounded gradients. That said, the refinement is hyper-parameter level: .
The authors also claimed that their results can be extended to several Adam variants such as AdamW and Muon.
Critical strengths
- The extensions to multiple Adam variants and stochastic settings improve the generalizability of the negative results, which may infer the uniform failure condition of the EMA-type first moment update.
- The simplification and self-contained proof of the non-convergence analysis.
Critical weaknesses
Significance of the work
- The main improvement over existing results appears to be extending the parameter range from to arbitrary . However, the condition is widely adopted in convergence analyses and is satisfied by commonly used practical settings. Therefore, the existing negative results already seem sufficient to demonstrate potential convergence failures in practically relevant regimes. I am not convinced that further extending the parameter range provides substantial practical value or new theoretical insight.
- From an intuitive perspective, Adam's failure to converge under adversarial gradient sequences is not particularly surprising. Since Adam's updates depend heavily on historical gradient information, one can imagine adversarial future gradients that conflict with this history and lead to undesirable updates. In this sense, the existence of such failure cases seems relatively natural. I would argue that a more interesting question is why Adam performs so well in practice despite these potential failures, rather than identifying rarely additional worst-case scenarios in which it fails.
Limited technical contribution
- The main result, Theorem 1.5, appears to introduce several nontrivial restrictions in exchange for covering a broader range of and . It is unclear whether this trade-off represents a meaningful improvement over the existing result (Theorem 1.4). In particular:
- The function class is not explicitly defined in this paper. Moreover, the analysis appears to narrow the function class from general convex functions, as considered in Reddi et al. (2018), to linear functions.
- Additional restrictions on : Theorem 1.5 imposes a series of restrictions on the step-size sequence that are absent from Theorem 1.4.
- Additional restrictions on : Theorem 1.5 also introduces new restrictions on the gradients, which I consider a more serious concern. Any additional assumptions on the function class should be carefully justified, especially when the goal is to strengthen an existing negative result. Otherwise, it becomes difficult to determine whether the improvement comes from a genuinely stronger analysis or simply from imposing more favorable conditions on the problem.
- The proof of the main theorem appears relatively standard and relies heavily on the additional restrictions mentioned above. In particular:
- The central construction still relies on periodic adversarial gradient sequences, where carefully designed gradients exploit the influence of historical information on Adam's updates. This is essentially the same mechanism underlying the counterexample in Reddi et al. (2018). I do not see a fundamentally new construction or theoretical insight beyond extending the applicable parameter range.
- Finally, the analysis simplifies Adam by omitting the bias-correction terms.
Questions for authors
- Since the parameter regime studied by Reddi et al. (2018) already covers commonly used practical settings, what additional theoretical insights or practical implications does the extension to arbitrary parameter choices offer?
- Could the authors explicitly specify the function class considered and clarify whether the construction extends beyond linear functions?
- Could the authors explain the necessity of the additional step-size conditions in Theorem 1.5 and how these conditions affect its comparison with Theorem 1.4?