- Rating
- 1
- Confidence
- 3
- Informativeness
- 2
- Presentation
- 1
- Soundness
- 2
Read review
Paper summary
This paper introduces a new term called forking under data replay in over-encoded transformers. It provides analysis on why forking happens under this setting and extends this to fine-tuning as well.
Critical strengths
Observing overfitting under data replay in over-encoding has not been previously studied and analysing this phenomenon is interesting.
Critical weaknesses
I am a big fan of analysis based papers, primarily because they offer more insights than a solution based paper. However I believe there are several critical weaknesses that I want the authors to address:
-
Forking is essentially "overfitting" (irrespective of whatever the setting is, i.e., over-encoding setting). This creates a lot of confusion because authors are just giving a new term to an already known phenomenon. It would be better if they remove the term "forking" and just say that the model is "overfitting".
-
Over-encoding has been the main theme of this paper, however, it has never been officially defined throughout the paper. It made it extremely difficult to understand what it really means. The authors should provide proper definition of over-encoding rather than just citing [1] (in line 68). Furthermore, they should provide a clear example of over-encoding by a giving a simple naive example. In this way, any naive reader can understanding what over-encoding even means in the first place.
-
The authors use a vanilla NanoGPT and DeepSeek model. However, they have not shown whether the trends hold for larger model sizes within these model families. Furthermore, no analysis has been done in other open-source models like Llama, Qwen etc. The trends can differ across model families and especially when sizes vary within a family. An experiment regarding this is required.
-
In line 140, the authors mentioned that "retrieved embeddings are injected at one of three routes— token representations before attention (input), attention values (v), or attention output (y)". This doesn't tell us whether the n-gram modules are inserted at every position or randomly. If it is randomly, then again we cannot tell inserting at which position has the impact on overfitting. A position-wise impact is required. Also, in Fig 3 there are considering one transformer block. Are these inserted at every transformer block (8 transformer blocks in NanoGPT and 12 in DeepSeek) or only at some of them. For a proper analysis, the authors should provide experiments whether there is a trend when insertion of these modules are compared within a transformer block (attention (input), attention values (v), or attention output (y)) and across transformer blocks (block 1,,...., block 12). Also, why is insertion of these modules not done after FFN/MLP?
-
In line 195 and 200, authors are talking about context frequency and table capacity, but never defined it - I still do not understand what they really mean by this after repeated reading of their paper. They must also provide concrete examples of this from their training corpus considered. In lines 225-226 the authors say that they count context frequencies and mask the n-gram based on a varying threshold. But again they never explained how they counted the context frequencies and masked the corresponding n-gram contributions. This is critical because as a practitioner I need to know how this was done.
-
Section 3.1 is introduced as an empirical scaling law, a scaling law is generally an equation which estimates a quantity based on some arguments (like test loss wrt model size, training data size etc). I was expecting something similar but nothing like that has been introduced. Hence, what is the point to even use such a section heading. The authors should change the title of the section to a more neutral line or provide a proper scaling law.
-
Section 4 of the paper, tries to explain why rare context frequency is the cause of the observed phenomenon and even defines something called as "context subspace". However, all subsections in Section 4 are written so poorly and are presented in an over-complex way for one to even understand. I still cannot understand what the authors even mean by Section 4 as a whole. Also, what is context subspace, the authors should define it properly.
-
In line 453, the authors say their study is limited due to scarce availability of open source over-encoding models. However, in their vanilla NanoGPT setting, they themselves added the n-gram modules. This means they can do the same for other open-source models and it is not a problem of availability.
Questions for authors
-
I believe the initial NanoGPT results are provided under pertaining, but what dataset has been used for it? I don't see any information regarding this.
-
In supervised finetuning setup (Section 5), are the authors using LoRA or full-fine tuning?
-
In Fig 7b of table freezing, why does the online gap suddenly decrease at the start of the second epoch, i.e., optimizer step 674? This is peculiar because this happens only when the n-gram modules are frozen (purple line) and not when they are trainable (blue line).
[1] Over-Tokenized Transformer: Vocabulary is generally worth scaling
If the authors wish to submit a rebuttal, I would like them to properly clarify all questions raised by me in Critical Weaknesses and Questions for Authors. (PS: I have not used any AI tool to review your paper).
[Update after seeing the rebuttal]
In the current form the paper has a lot of writing-related, title-related, lack of experiments issues as stated above, which I don't believe can be resolved in the current review cycle. Hence, due to all these reasons, I standby my current rating. I hope the authors can carefully read and utilize the above comments to improve their paper for the next conference submission.
Hi authors, I'll read your rebuttal and get back to you in the next 1-2 days.