- Rating
- 1
- Confidence
- 3
- Informativeness
- 1
- Presentation
- 1
- Soundness
- 1
Read review
Paper summary
The paper studies Learning MPC (LMPC) on nonlinear systems. LMPC's improvement guarantee is proved for a terminal state that lies exactly on a stored state. The authors argue that implementations only reach a neighborhood of the stored states, so the guarantee depends on how the terminal cost is extended off the store. They define a "consistency leak," a one-step Bellman residual, and show that iteration cost can increase by at most the leak times the iteration length. They then compare several terminal-cost constructions and propose a per-trajectory minimum: take the nearest neighbor within each stored trajectory, then the minimum over trajectories. Experiments on a kinematic bicycle, a planar quadrotor and a MuJoCo quadrotor report better completion and cost than a pooled nearest-neighbor lookup.
Critical strengths
The proposed per-trajectory minimum is simple, computationally cheap and easy to implement. The paper correctly points out that relaxed nonlinear LMPC implementations have no improvement guarantee. The authors mention limitations and report negative and null results. The experiments include sanity checks and paired statistical tests.
Critical weaknesses
The paper's language does not follow the usual tone and standards in the field, with lots of new terms and definitions introduced ad hoc, which makes it difficult to connect to the theoretical development already existing in the field. This reduces readability. The authors should do a major overhaul to the presentation and framing of the paper in light of existing works in the literature and standard terminology. Already in the opening section, "promising exactly what the controlled vehicle (the ego) is already doing; such a value is inert" is difficult to understand and quite uncommon in similar scientific writing in the field. The paper has numerous such instances where the reader is lost.
The original body of work uses the safe set points as terminal conditions on the optimization problem and does not require reaching the exact state. The argument about reaching a specific state being a measure zero event is difficult to argue as this does not mean the state is unreachable but rather changes the nature of the required optimization problem (using integer variables) and the original proof relies on reaching the set, which is always feasible by construction. Points about relaxations losing some of the guarantees already appear in published work; therefore, the niche presented in this paper is not clear. The problem claimed in the submission is not clear and not consistent with the published body of work, severely undermining the contribution of the paper.
The optimal control problem posed in (4) is not the original LMPC algorithm, but a relaxation of it on the terminal constraints, which results in the leak structure the authors are posing. Therefore, the authors should frame their claimed contributions carefully as the approximation and the recovered solution for exact penalization are not well founded. The original problem poses a mixed-integer nature, forcing the trajectories to reach one of those in the safe set, which is always possible by construction, so the presentation in the submission seems somewhat contrived. Do the authors take a relaxed practical implementation of LMPC and study the suboptimality of this method with respect to an ideal one? This point is not clear and the rest of the paper becomes confusing due to it.
The benefit of the presented work over the existing body of work is not clear and the authors do not justify the improvement over the baselines sufficiently.
Questions for authors
- The definition of p() in Definition 2 is not clear.
- Please define where problem (4) is taken from, or whether you have developed this solution concept yourselves. By allowing a distance to the SS, you are indeed relaxing the problem and changing the LMPC structure and Algorithm 1 does not reflect the original algorithm. Please explain this choice and what it means for the rest of the paper.
- The statement in Section 4.2 about how the terminal set is enforced in the original LMPC work is incorrect. The authors should either point out to how and where in the cited paper this relaxation is used with the stated theoretical results or revise the paper significantly to reword their developments.
- Can you clarify the definitions of nonstandard terminology of lap, circuit, etc., which are difficult to follow and are used inconsistently in some places?
- Please compare your proposed method to the exact formulation on the original paper for the experimental results and report the performance differences. How did you verify the exactness of your solutions with the penalization method in the implementations?