- Rating
- 2
- Confidence
- 3
- Informativeness
- 2
- Presentation
- 2
- Soundness
- 2
Read review
Paper summary
This paper proposes FedSGR, a federated graph learning framework that integrates spatial topological information with frequency-domain signals to address non-IID graph data. To achieve this, the authors first introduce local geometric enhancement, allowing each client to construct personalized product manifolds combining Euclidean, hyperbolic, and spherical spaces. They then share global spectral knowledge by computing local graph Laplacian spectra and obtaining frequency weights through a spectral encoder and a shared filter generator. Finally, they propose spectral-guided dual-gated Riemannian convolution, which combines local Forman–Ricci curvature signals with global spectral guidance to determine neighbor-aggregation weights and perform message passing on the product manifolds. The method outperforms the compared FGL methods across its experimental settings, but it has some flaws in novelty, experiments, and the theory part.
Critical strengths
The method outperforms the compared FGL methods across its experimental settings
Critical weaknesses
I appreciate the work and FedSGR's performance, so with clarifications on these aspects in the authors’ response, I would be willing to increase the score.
Regarding novelty, this paper’s main contribution seems to be combining existing techniques. FedRGL has already discussed personalized mixed-curvature spaces and Ricci-gated convolution, while FedSSP has studied globally shared spectral knowledge with client-specific personalization. Although combining these techniques may be useful and achieve SOTA, the experiments do not sufficiently establish the proposed integration's independent contribution.
In particular, FedRGL is not included as a baseline. The w/o S ablation cannot replace this comparison because it may not faithfully implement FedRGL. Similarly, the w/o G ablation replaces the entire message-passing stack, so it cannot independently demonstrate the effectiveness of spectral–Ricci fusion over existing Ricci gating. This makes it difficult to determine how much of the performance improvement comes from the proposed fusion rather than the existing components.
The theoretical analysis contains an issue. Proposition 1 claims that global spectral guidance reduces cross-client gradient divergence. However, the derivation in Equation (22) omits the cross term when bounding the squared norm of the combined spatial and spectral gradient deviations. The final cross term cannot be omitted without additional assumptions. Also, the Lipschitz continuity of the spectral filter generator does not by itself establish that spectral gradient divergence is significantly smaller than spatial divergence. Therefore, the theoretical guarantee in Theorem 1 is not established by the current proof.
Questions for authors
Some details in the experiment need clarification:
- Section 4.5 describes the fusion weights (w_s) and (w_g) as client-specific learnable scalars. However, Appendix E.2 states that the default setting is (w_s=w_g=0.5), while Appendix E.3 introduces learnable weights separately as FedSGR-LS. This should be clarified: whether the main results in Table 1 use fixed or learnable weights.
- The reported results differ between Table 1 and Appendix Table 9 under the 10-client setting. One mismatch is that Table 1 reports PubMed accuracy of 72.30%, while Table 9 reports 85.21%.
Dear reviewer i7JV and 7BJK,
The authors have responded to your concerns. Please review their responses as soon as possible and provide any necessary feedback. Thank you.
AC