- Rating
- 1
- Confidence
- 2
- Informativeness
- 1
- Presentation
- 1
- Soundness
- 2
Read review
Paper summary
The paper studies FDR control over structured hypothesis spaces. It estimates this probability using a regularized mixture likelihood and proposes two decision rules: one combines spatial local-fdr ranking with marginal local-fdr accounting, while the other uses mirror statistics. The paper provides conditional FDR guarantees for the first rule, an mFDR bound with a slack term for the second, and an exact FDR guarantee for a masked variant.
Critical strengths
The paper addresses an interesting and practically relevant problem: FDR control in structured hypothesis spaces. Using relationships among hypotheses to improve discovery power is a worthwhile direction, and the proposed kernel formulation offers a flexible way to incorporate different types of structure.
Critical weaknesses
-
The validity guarantee for Rule 1 does not cover the implemented procedure. Theorem C.1 requires the PC condition, but the paper does not establish that the proposed RKHS-based ordering satisfies it. The theorem also uses the true marginal parameters , whereas the implemented procedure uses their estimates, without analyzing the effect of this substitution. These gaps leave the statistical validity of the proposed Rule 1 unresolved.
-
The practical meaning of Rule 2's control guarantee is unclear. The bound contains a term that does not vanish with when is fixed. The paper does not report the selected values or establish that the resulting bound is informative in the experimental settings. Meanwhile, the masked variant has an exact FDR guarantee, but its performance is not separately reported. Consequently, the experiments do not show whether the version with an exact guarantee retains the claimed power advantage.
Questions for authors
-
Under what conditions does the proposed RKHS-based ordering satisfy PC? Does the control guarantee remain valid when the true marginal parameters are replaced by the estimates used in the experiments?
-
What search range and selected values of were used in each experiment? Can the resulting error bound be quantified sufficiently to determine whether it is nontrivial? Does the analysis cover the cross-validation selection used in the implementation?
-
Why do several BH results exceed the nominal FDR level under the stated independent, uniform-null simulation setup? The conditions of BH should be weaker than your methods, right? Are the results of the simulation correct?
-
Was the masked Rule 2 evaluated? If so, please report its FDR and power under the same settings. If not, can a direct comparison be provided to establish whether the claimed power advantage persists for the version with an FDR guarantee?